-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolchain with new versions of FPGA tools and remove fw/apps/programmer toolschains #267
Conversation
d963cf5
to
5a9057c
Compare
Nice!
|
4a81fb2
to
b05b4d2
Compare
About 2.5 GB
Yes
Updated |
1785807
to
7464321
Compare
I have tested all make targets in all Makefiles, and all CI jobs. Found some issues not related to the OCI image, pushed fix to #271 Comments:
|
Apart from my previous comments, I'm happy. I still want @mchack-work to take a look, since he has more history with our OCI-image. |
7464321
to
7b4492f
Compare
Done
We could use scan-build instead, and that is already included from the clang-tools package that is a dependency from clang-tidy. |
7b4492f
to
fd6c315
Compare
fd6c315
to
502aa7e
Compare
Relates to #272 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have:
- built the OCI image with podman.
- built bitstream.
- tested the design on target hardware.
Everything works. Nice work!
There's a false positive, sort of, in the CI. The check-hashes job passes but if one uses the image built from our new Dockerfile the hashes are different. I don't think we should do anything with it in this branch but it's good to be aware of it when we publish the new image in the registry and start using it.
CI fails for the check-verilog job. That's because the verilog linter in tkey-builder:4 is confused by the flags now used. This means CI will always fail until we change to a new tkey-builder version in the CI... Can we postpone the changes to the Makefile until we have published the new tkey-builder?
502aa7e
to
5485faa
Compare
…rogrammer toolschains - Change docker image to ubuntu 24.04 - Add new versions of: * clang (18.1.3, part of ubuntu 24.04) * icestorm (commit 738af822905fdcf0466e9dd784b9ae4b0b34987f) * yosys (0.45) * nextpnr (0.7) + extra patches for RNG seed handling and early exit * iverilog (v12) * verilator (v5.028) * verible (v0.0-3795) * cocotb (v1.9.1) - Remove: * gcc-arm-none-eabi * libnewlib-arm-none-eabi * libstdc++-arm-none-eabi-newlib * pico-sdk * golang
5485faa
to
f666174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed CI: we apply the lint flag changes to the Makefile later when we change the tkey-builder version used in CI.
Not very happy with code patching, even if it's small, in the Dockerfile but since things are moving so fast I don't see any alternatives either than maintaing a fork of nextpnr of our own. That seems like too much work. We will have to revisit this later, I think.
I think some of the git clones can be replaced by using actual release tar balls sometimes, which might be preferable. We might also want to include digests to see that the downloaded file is what we expected.
I'll open issues for these things but approve for now so we can continue working.
Description
Type of change
Please tick any that are relevant to this PR and remove any that aren't.
Submission checklist