Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify building a firmware for qemu #263

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Simplify building a firmware for qemu #263

merged 2 commits into from
Sep 19, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Sep 6, 2024

Description

  • Remove the define NOCONSOLE, add define QEMU_CONSOLE instead.
  • Inverse the use of it, add the define to have QEMU debug output in fw. Making it simpler to create a different make target.
  • Add a make target qemu_firmware.elf which builds the firmware with QEMU console enabled.
  • Also fixing the warning one gets when building with QEMU_CONSOLE defined.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes tk1: new name of define to enable HTIF when building firmware qemu#29

dehanj and others added 2 commits September 19, 2024 16:51
- Remove the define `NOCONSOLE`, add define `QEMU_CONSOLE`
- Inverse the use of it, add the define to have QEMU debug output in fw.
- Add a make target `qemu_firmware.elf` which builds the firmware with
  QEMU console enabled.

Co-authored-by: Mikael Ågren <[email protected]>
@mchack-work
Copy link
Member

Updated docs in firmware's README about the new QEMU_CONSOLE.

Updated copyright year in changed files.

Squashed into earlier commits.

Merging.

Copy link
Member

@mchack-work mchack-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchack-work mchack-work merged commit 81950ef into main Sep 19, 2024
5 checks passed
@dehanj dehanj deleted the build_qemu_fw branch September 20, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants