Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a make target and script that runs the secret generation. #232

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Jun 7, 2024

The intention is to simplify building a complete bitstream as a user not
using the repo everyday. Also added a simple script that can provide
some guiding errors if some prerequisite is missing.

A proposal is to extend the script to also include the flashing of nvcm, with instruction along the way.

@dehanj dehanj requested a review from mchack-work June 7, 2024 09:03
@dehanj dehanj marked this pull request as draft June 7, 2024 09:03
The intention is to simplify building a complete bitstream as a user not
using the repo everyday. Also added a simple script that can provide
some guiding errors if some prerequisite is missing.
@mchack-work
Copy link
Member

Looks good so far.

Should we have two scripts, one for NVCM and one for flash? Or is the intention to only use the script for NVCM?

@dehanj
Copy link
Member Author

dehanj commented Jun 26, 2024

Looks good so far.

Should we have two scripts, one for NVCM and one for flash? Or is the intention to only use the script for NVCM?

Good question. I can think of a few solutions.

  1. Two scripts, one for NVCM and one for flash.
  2. One script, that is interactive. More or less asks for prompts along the way to choose NVCM or flash.

What do your think?
Hmm, I believe that 1 is simpler, more explicit and less error prone.

@mchack-work
Copy link
Member

I agree. Using two scripts is safer. A user who mistypes can be catastrophic if it's just a question. Unless, maybe, we demand that they type in I AM REALLY HAPPY WITH MY DESIGN in all caps, or something.

But two scripts seems good to me.

@dehanj
Copy link
Member Author

dehanj commented Oct 9, 2024

Added a new WIP script, that does not use predefined make targets, but runs the commands directly.
The idea with that script is that it can be run without even having the repo cloned, it will download it for you.

An idea is to add so one can give a path to point to a repo if one has already cloned it for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants