Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing names for ram address and data randomization #220

Closed
wants to merge 2 commits into from

Conversation

secworks
Copy link
Contributor

This PR is first attempt att fixing #219. Needs review and checks.

The build of the FPGA gives different results with the patch compared to main. The build should not be affected by simple name changes.

@dehanj
Copy link
Member

dehanj commented May 13, 2024

The CI job check-hashes actually spits out the shasum of application_fpga.bin before it compares, so one easier can compare to the one you get locally with tkey-builder:4.

CI's calculated checksum from the logs

sha256sum application_fpga.bin
4095aaa97f41eba88b6ca846eb1cc81e84f368a86be747809490bb9beab20cb6  application_fpga.bin

@mchack-work
Copy link
Member

mchack-work commented May 13, 2024

Rebasing on main gets rid of the merge commit present in this branch and brings in a change for .gitignore.

Verified that the checksum on application_fpga.bin still is different than expected.

Last commit before the name changes, commit 0454e02, from main works fine.

Looked through carefully to see if any constants have changed. Only differences in, say, strings I have found are in the testbench, which shouldn't influence application_fpga.bin at all.

@secworks
Copy link
Contributor Author

Done a lot of testing and added fixes step by step in branch https://github.com/tillitis/tillitis-key1/tree/219_new_names_again
Finally identify the issue to be the name of the registers used to store the parameters. If the name contain 'addr' or 'data' the implementation is changed: The number or resources allocated, and of course, the digest. Changing name to 'addraddraddr' still triggers the issue. 'eddr' however does not.

Sent email with a description of the issue to Yosys 2024-06-04.

@dehanj
Copy link
Member

dehanj commented Jun 27, 2024

Closing this in favor of #229

@dehanj dehanj closed this Jun 27, 2024
@dehanj dehanj deleted the 219_change_names_ram_random branch June 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants