*: reduce rand NewSource #8675
*: reduce rand NewSource #8675
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
reduce-rand-source
branch
from
dac2d7f
to
34852ed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8675 +/- ##
==========================================
- Coverage 77.62% 77.57% -0.05%
==========================================
Files 474 474
Lines 62355 62359 +4
==========================================
- Hits 48401 48374 -27
- Misses 10395 10427 +32
+ Partials 3559 3558 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -67,40 +71,40 @@ func (*ReplicaChecker) GetType() types.CheckerSchedulerType { | |||
| } | |||
|
|
|||
| // Check verifies a region's replicas, creating an operator.Operator if need. | |||
| func (r *ReplicaChecker) Check(region *core.RegionInfo) *operator.Operator { | |||
| func (c *ReplicaChecker) Check(region *core.RegionInfo) *operator.Operator { | |||
There was a problem hiding this comment.
Does it seem to contain the change from another pr?
There was a problem hiding this comment.
No, this change is needed since we use r as the field's naming.
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rleungx: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Close #8674.
What is changed and how does it work?
Initialize rand when creating schedulers and checkers instead of initializing it every time scheduling.
Check List
Tests
Release note