pkg: add hot write tests (#7851)

ref #7848 Signed-off-by: Ryan Leung <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
tikv · Feb 26, 2024 · d21c626 · d21c626
1 parent 6822137
commit d21c626
Showing 1 changed file with 55 additions and 0 deletions.
diff --git a/pkg/schedule/schedulers/hot_region_test.go b/pkg/schedule/schedulers/hot_region_test.go
@@ -203,6 +203,7 @@ func TestHotWriteRegionScheduleByteRateOnly(t *testing.T) {
 	statisticsInterval = 0
 	checkHotWriteRegionScheduleByteRateOnly(re, false /* disable placement rules */)
 	checkHotWriteRegionScheduleByteRateOnly(re, true /* enable placement rules */)
+	checkHotWriteRegionPlacement(re, true)
 }
 
 func TestSplitIfRegionTooHot(t *testing.T) {
@@ -393,6 +394,60 @@ func TestSplitBucketsByLoad(t *testing.T) {
 	}
 }
 
+func checkHotWriteRegionPlacement(re *require.Assertions, enablePlacementRules bool) {
+	cancel, _, tc, oc := prepareSchedulersTest()
+	defer cancel()
+	tc.SetEnableUseJointConsensus(true)
+	tc.SetClusterVersion(versioninfo.MinSupportedVersion(versioninfo.ConfChangeV2))
+	tc.SetEnablePlacementRules(enablePlacementRules)
+	labels := []string{"zone", "host"}
+	tc.SetMaxReplicasWithLabel(enablePlacementRules, 3, labels...)
+	hb, err := CreateScheduler(utils.Write.String(), oc, storage.NewStorageWithMemoryBackend(), nil)
+	re.NoError(err)
+	tc.SetHotRegionCacheHitsThreshold(0)
+
+	tc.AddLabelsStore(1, 2, map[string]string{"zone": "z1", "host": "h1"})
+	tc.AddLabelsStore(2, 2, map[string]string{"zone": "z1", "host": "h2"})
+	tc.AddLabelsStore(3, 2, map[string]string{"zone": "z2", "host": "h3"})
+	tc.AddLabelsStore(4, 2, map[string]string{"zone": "z2", "host": "h4"})
+	tc.AddLabelsStore(5, 2, map[string]string{"zone": "z2", "host": "h5"})
+	tc.AddLabelsStore(6, 2, map[string]string{"zone": "z2", "host": "h6"})
+	tc.RuleManager.SetRule(&placement.Rule{
+		GroupID: "pd", ID: "leader", Role: placement.Leader, Count: 1, LabelConstraints: []placement.LabelConstraint{{Key: "zone", Op: "in", Values: []string{"z1"}}},
+	})
+	tc.RuleManager.SetRule(&placement.Rule{
+		GroupID: "pd", ID: "voter", Role: placement.Follower, Count: 2, LabelConstraints: []placement.LabelConstraint{{Key: "zone", Op: "in", Values: []string{"z2"}}},
+	})
+	tc.RuleManager.DeleteRule("pd", "default")
+
+	tc.UpdateStorageWrittenBytes(1, 10*units.MiB*utils.StoreHeartBeatReportInterval)
+	tc.UpdateStorageWrittenBytes(2, 0)
+	tc.UpdateStorageWrittenBytes(3, 6*units.MiB*utils.StoreHeartBeatReportInterval)
+	tc.UpdateStorageWrittenBytes(4, 3*units.MiB*utils.StoreHeartBeatReportInterval)
+	tc.UpdateStorageWrittenBytes(5, 3*units.MiB*utils.StoreHeartBeatReportInterval)
+	tc.UpdateStorageWrittenBytes(6, 6*units.MiB*utils.StoreHeartBeatReportInterval)
+
+	// Region 1, 2 and 3 are hot regions.
+	addRegionInfo(tc, utils.Write, []testRegionInfo{
+		{1, []uint64{1, 3, 5}, 512 * units.KiB, 0, 0},
+		{2, []uint64{1, 4, 6}, 512 * units.KiB, 0, 0},
+		{3, []uint64{1, 3, 6}, 512 * units.KiB, 0, 0},
+	})
+	ops, _ := hb.Schedule(tc, false)
+	re.NotEmpty(ops)
+	re.NotContains(ops[0].Step(1).String(), "transfer leader")
+	clearPendingInfluence(hb.(*hotScheduler))
+
+	tc.RuleManager.SetRule(&placement.Rule{
+		GroupID: "pd", ID: "voter", Role: placement.Voter, Count: 2, LabelConstraints: []placement.LabelConstraint{{Key: "zone", Op: "in", Values: []string{"z2"}}},
+	})
+	tc.RuleManager.DeleteRule("pd", "follower")
+	ops, _ = hb.Schedule(tc, false)
+	re.NotEmpty(ops)
+	// TODO: fix the test
+	// re.NotContains(ops[0].Step(1).String(), "transfer leader")
+}
+
 func checkHotWriteRegionScheduleByteRateOnly(re *require.Assertions, enablePlacementRules bool) {
 	cancel, opt, tc, oc := prepareSchedulersTest()
 	defer cancel()