Encapsulate sf_grob() in GeomSf$draw_panel()
#5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into sf_remove_missing # Conflicts: # R/geom-sf.R
|
@teunbrand after this refactor |
|
No that is not intentional, thanks for reporting on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not really solve an open issue, but does make
GeomSfmore consistent with other geoms.Briefly,
sf_grob()was a wrapper forsf::st_as_grob()that did two things that are usually handled by Geom classes.It removed missing data, which is usually handled by
Geom$handle_na(), and wrangles the graphical parameters for a grob, which is usually done inGeom$draw_panel().This PR divides these two responsibilities to the appropriate places in the class.