fixes string interpolation failure for splines #1381
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topepo
commented
Oct 18, 2024
| @@ -46,6 +46,14 @@ spline2_create <- function(x, nm = "pred", .fn = "bSpline", df = 3, complete_set | |||
|
|
|||
| spline_msg <- function(x) { | |||
| x <- as.character(x) | |||
| # Error messages can contain brackets (e.g. "Error in if (df < 0) { : missing value") | |||
There was a problem hiding this comment.
A lot of comments so that future me/us will get the logic
topepo
commented
Oct 18, 2024
| # to change the delimiters but will ignore them if they are doubled. So we | ||
| # change "{" to "{{" (and also for close). Simultaneous substitution via | ||
| # `pattern = "(\\{)|(\\})"` produces poor results so we do them one at a time. | ||
| x <- gsub("(\\{)", "\\1\\1", x) |
There was a problem hiding this comment.
Maybe this can be done in one shot?
There was a problem hiding this comment.
I'm perfectly fine to do it one at a time. we are throwing an error when this code is run so speed isn't an issue
topepo
commented
Oct 18, 2024
| @@ -1,6 +1,6 @@ | |||
| Package: recipes | |||
| Title: Preprocessing and Feature Engineering Steps for Modeling | |||
| Version: 1.1.0.9000 | |||
There was a problem hiding this comment.
So that I can updates tests/skips in tune
topepo
commented
Oct 18, 2024
| @@ -46,6 +46,14 @@ spline2_create <- function(x, nm = "pred", .fn = "bSpline", df = 3, complete_set | |||
|
|
|||
| spline_msg <- function(x) { | |||
There was a problem hiding this comment.
For next week: pass the upstream caller env to avoid "Caused by error in spline_msg():"
topepo
added a commit
to tidymodels/tune
that referenced
this pull request
Oct 18, 2024
EmilHvitfeldt
approved these changes
Oct 18, 2024
| # to change the delimiters but will ignore them if they are doubled. So we | ||
| # change "{" to "{{" (and also for close). Simultaneous substitution via | ||
| # `pattern = "(\\{)|(\\})"` produces poor results so we do them one at a time. | ||
| x <- gsub("(\\{)", "\\1\\1", x) |
There was a problem hiding this comment.
I'm perfectly fine to do it one at a time. we are throwing an error when this code is run so speed isn't an issue
|
looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1380
Created on 2024-10-18 with reprex v2.1.1