Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning message when scaling steps return NaN #1252

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Add warning message when scaling steps return NaN #1252

merged 9 commits into from
Nov 16, 2023

Commits on Nov 1, 2023

  1. add warning message when scaling returns NaN 

    add scaling steps warning test

change test and warning text
    @mastoffel
    mastoffel committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c211023 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2023

  1. change expect_warning to expect_snapshot

    @mastoffel
    mastoffel committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    512f3fc View commit details
    Browse the repository at this point in the history

  2. change step_scale NaN warning to cli_warn()

    @mastoffel
    mastoffel committed Nov 4, 2023
    Configuration menu
    Copy the full SHA
    520dbce View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2023

  1. add NaN warning to step_range and step_center 

    update NEWS.md
    @mastoffel
    mastoffel committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    d734011 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. update news

    @EmilHvitfeldt
    EmilHvitfeldt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    28e2942 View commit details
    Browse the repository at this point in the history

  2. fix spacing

    @EmilHvitfeldt
    EmilHvitfeldt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f6e95f8 View commit details
    Browse the repository at this point in the history

  3. add a couple of expert_snapshot()

    @EmilHvitfeldt
    EmilHvitfeldt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    ed80752 View commit details
    Browse the repository at this point in the history

  4. update snapshots

    @EmilHvitfeldt
    EmilHvitfeldt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a716468 View commit details
    Browse the repository at this point in the history

  5. also test step_normalize()

    @EmilHvitfeldt
    EmilHvitfeldt committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c469552 View commit details
    Browse the repository at this point in the history