loopify step_classdist() #1183
Merged
loopify step_classdist() #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
Aug 2, 2023
| @@ -230,34 +230,40 @@ mah_pooled <- function(means, x, cov_mat) { | |||
|
|
|||
| #' @export | |||
| bake.step_classdist <- function(object, new_data, ...) { | |||
| if (length(object$objects[[1]]$center) == 0) { | |||
| col_names <- names(object$objects[[1]][[1]]) | |||
There was a problem hiding this comment.
Transitioning to selection by position has me a little 🤨 but this looks safe.
There was a problem hiding this comment.
Yes, this wasn't ideal, but it is because the information is in two different places depending on pool. But it just happens to be that names(object$objects[[1]][[1]]) captures both places 😄
There was a problem hiding this comment.
also, the positioning is just "first"
Co-authored-by: Simon P. Couch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1156.
This PR does a small refactor to
step_classdist()to bring them up to the same standard as #1156.