loopify step_profile() #1177
Merged
loopify step_profile() #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
commented
Jul 31, 2023
|
|
||
| for (i in names(object$columns)) { | ||
| new_data[[i]] <- rep(object$columns[[i]], n) | ||
| new_data <- list() |
There was a problem hiding this comment.
I found it easier to create a empty list, fill it, order it, tibblify it. Than to modify the existing tibble, order it making sure the lengths matched
EmilHvitfeldt
commented
Jul 31, 2023
| new_data[[names(object$profile)]] <- object$profile[[1]] | ||
|
|
||
| new_data <- vctrs::vec_recycle_common(!!!new_data) |
There was a problem hiding this comment.
This function is so cool! We can avoid doing rep(value, n)
aaa <- list(1, 2, 4, 1:5)
vctrs::vec_recycle_common(!!!aaa)
#> [[1]]
#> [1] 1 1 1 1 1
#>
#> [[2]]
#> [1] 2 2 2 2 2
#>
#> [[3]]
#> [1] 4 4 4 4 4
#>
#> [[4]]
#> [1] 1 2 3 4 5
simonpcouch
approved these changes
Aug 1, 2023
Co-authored-by: Simon P. Couch <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1156.
This PR does a small refactor to
step_profile()to bring them up to the same standard as #1156.This step is quite different that most other steps as it doesn't use the
new_datainbake(), so many of the check functions we normally use shouldn't be done here.