Merge pull request #1372 from tidymodels/stricter-sparsevctrs-tests

Stricter sparsevctrs tests
tidymodels · Sep 16, 2024 · a56d6f3 · a56d6f3
2 parents 377f7d5 + a18b7f9
commit a56d6f3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -34,7 +34,7 @@ Imports:
     Matrix,
     purrr (>= 1.0.0),
     rlang (>= 1.1.0),
-    sparsevctrs (>= 0.1.0.9000),
+    sparsevctrs (>= 0.1.0.9001),
     stats,
     tibble,
     tidyr (>= 1.0.0),

diff --git a/R/misc.R b/R/misc.R
@@ -218,6 +218,8 @@ n_complete_rows <- function(x) {
     x[[pos_list_col]] <- purrr::map_lgl(x[[pos_list_col]], flatten_na)
   }
 
+  x <- x[, vapply(x, anyNA, logical(1))]
+
   sum(vec_detect_complete(x))
 }
 

diff --git a/tests/testthat/test-sparsevctrs.R b/tests/testthat/test-sparsevctrs.R
@@ -1,5 +1,6 @@
 test_that("recipe() accepts sparse tibbles", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()
   hotel_data <- sparsevctrs::coerce_to_sparse_tibble(hotel_data)
@@ -31,6 +32,7 @@ test_that("recipe() accepts sparse tibbles", {
 
 test_that("prep() accepts sparse tibbles", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()
   hotel_data <- sparsevctrs::coerce_to_sparse_tibble(hotel_data)
@@ -56,6 +58,7 @@ test_that("prep() accepts sparse tibbles", {
 
 test_that("bake() accepts sparse tibbles", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()
   hotel_data <- sparsevctrs::coerce_to_sparse_tibble(hotel_data)
@@ -82,6 +85,7 @@ test_that("bake() accepts sparse tibbles", {
 
 test_that("recipe() accepts sparse matrices", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()
 
@@ -112,6 +116,7 @@ test_that("recipe() accepts sparse matrices", {
 
 test_that("prep() accepts sparse matrices", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()
 
@@ -136,6 +141,7 @@ test_that("prep() accepts sparse matrices", {
 
 test_that("bake() accepts sparse matrices", {
   skip_if_not_installed("modeldata")
+  withr::local_options("sparsevctrs.verbose_materialize" = 3)
 
   hotel_data <- sparse_hotel_rates()