-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync update workflow to upstream #30
Open
jfx2006
wants to merge
9
commits into
main
Choose a base branch
from
sync2upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eemeli
suggested changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .l10n-ignore file should also be added.
.github/CODEOWNERS
Outdated
@@ -2,5 +2,4 @@ | |||
* @thunderbird/l10n-thunderbird | |||
|
|||
# Code reviewers (workflows, scripts) | |||
/_scripts/ @thunderbird/build-release @jfx2006 | |||
/.github/ @thunderbird/build-release @jfx2006 | |||
/.github/ @mozilla-l10n/l10n-firefox @jfx2006 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/.github/ @mozilla-l10n/l10n-firefox @jfx2006 | |
/.github/ @jfx2006 |
jfx2006
force-pushed
the
sync2upstream
branch
from
October 14, 2024 14:52
5a64f41
to
f278358
Compare
eemeli
approved these changes
Oct 14, 2024
Co-authored-by: Francesco Lodolo <[email protected]> (cherry picked from commit b2b5e264aa40689e3b86d464c9d9c4611630387f)
(cherry picked from commit d7f634e71bc834efab43eff4743dd8f0383b8fe4)
(cherry picked from commit a22571280bb94f44ee1db8d85fe6322c58b19fca)
* Move _scripts/ -> .github/scripts/ * Move _configs/config.json -> .github/update-config.json (cherry picked from commit 54d5b533dca61a35f3e64c8014df941ee759700a)
(cherry picked from commit 9c49088e0fbd2ff64ddeb5f4cb17f7bb10fcacbf)
(cherry picked from commit 95fd0cd3f3beb28214958ff5da0fd9db6eb384cb)
Co-authored-by: Eemeli Aro <[email protected]> (cherry picked from commit 115b013baf86c3eae0eb35330a812a980c783266)
jfx2006
force-pushed
the
sync2upstream
branch
from
October 25, 2024 14:34
f278358
to
6a8aaff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference from upstream is the addition of the cfg_load_override function. This is needed to ignore the "missing" TOML files from mozilla-central.