-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to latest glutin #230
Conversation
@@ -111,6 +112,8 @@ impl Builder { | |||
.with_title(self.title.clone()); | |||
|
|||
let context = glutin::ContextBuilder::new() | |||
.with_gl_profile(GlProfile::Core) | |||
.with_gl(GlRequest::Latest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather prefer to see a specific version here. @kvark what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some older GPUs only support GL 2.1, while some macs do not support older GL 2x. So if we are completely pedantic, we can't have a specific version requirement (even though, practically, GL 3.2 would fit most cases). So having Latest
here is fine.
Sorry for these small problems. Will three.rs plan to support gfx-hal, because I found that the opengl was not that enough. How about supporting rendy ? |
@happydpc I think it would make more sense to base on wgpu-rs for this project instead of gfx/rendy. See #83 (comment) and #222 |
Yes, that's true. I had a try on wgpu-rs yesterday, it will be cool if running on web browsers in the future instead of by poor WebGL library. I am planning to port some examples in https://github.com/SaschaWillems/Vulkan with wgpu-rs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Bors r=vitvakatu
… On Sep 10, 2019, at 03:11, Ilya Bogdanov ***@***.***> wrote:
@vitvakatu approved this pull request.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
230: update to latest glutin r=vitvakatu a=happydpc Co-authored-by: happydpc <[email protected]>
Build succeeded |
No description provided.