[WIP] Add TTL of cached documents in response headers #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
do-not-merge/work-in-progress
sesheta
added
the
size/S
KPostOffice
reviewed
Sep 2, 2022
| @@ -573,6 +578,7 @@ def post_advise_python( | |||
| "parameters": parameters, | |||
| }, | |||
| 202, | |||
| {"x-thoth-cached-document-ttl": cache_ttl}, | |||
There was a problem hiding this comment.
Does the third element in the tuple map to headers?
harshad16
requested changes
Sep 13, 2022
| @@ -1062,6 +1069,7 @@ def post_build( | |||
| "buildlog_document_id": buildlog_document_id, | |||
| }, | |||
| 202, | |||
| {"x-thoth-cached-document-ttl": cache_ttl}, | |||
There was a problem hiding this comment.
This is missing from the schema
Line 889 in 1aab302
mayaCostantini
force-pushed
the
cached-results-ttl
branch
from
1aab302
to
582680a
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Related to #1614
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Add TTL for cached documents in HTTP response headers for the following endpoints:
/advise/python/analyze/build-analysis/provenance/pythonDescription
This PR is a work in progress: