Fix NULL values considered distinct by Postgres < 15 #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/M
|
Needs #2737 to be merged for tests to pass. |
|
/retest |
|
Would you mind adding some explanation of how that `postgresql_where`
solves the issue in the commit message (possibly, links to the
documentation) ?
It's not immediately clear just looking at the code.
|
postgresql_where parameter to the python_package_version_entity_idx (see link to doc in code)
mayaCostantini
force-pushed
the
fix-package-index-dup
branch
from
0e44f15
to
321adf2
Compare
|
Thanks ! |
|
And I can approve here, o/ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Related to #2729
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Fix NULL values considered as distinct by postgres versions < 15. This would possibly enforce the unique constraint set on package version and avoid duplicate package entries in the database table
PythonPackageVersionEntity.