fix: make Hecke have only one is_absolutely_irreducible (#1425)

thofma · Mar 2, 2024 · c2792d8 · c2792d8 · thofma · Mar 2, 2024
1 parent 6599c41
commit c2792d8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Hecke"
 uuid = "3e1990a7-5d81-5526-99ce-9ba3ff248f21"
-version = "0.30.0"
+version = "0.30.1"
 
 [deps]
 AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"

diff --git a/src/Hecke.jl b/src/Hecke.jl
@@ -559,6 +559,17 @@ function checkbounds(a::Int, b::Int) nothing; end;
 ################################################################################
 add_assertion_scope(:PID_Test)
 
+################################################################################
+#
+#  Function stub
+#
+################################################################################
+
+# - The following function is introduced in src/ModAlgAss/*
+# - The Hecke.MPolyFactor submodule wants to extend it, but is loaded earlier
+# - Introduce the function here, to make everyone happy
+function is_absolutely_irreducible end
+
 ################################################################################
 #
 #  "Submodules"

diff --git a/src/NumField/NfAbs/MPolyAbsFact.jl b/src/NumField/NfAbs/MPolyAbsFact.jl
@@ -1,13 +1,12 @@
 module MPolyFact
 
-using Hecke
-using Hecke: Nemo, find_morphism, rational_reconstruction
-import Hecke: set_precision!, set_precision
+using ..Hecke
+using ..Hecke: Nemo, find_morphism, rational_reconstruction
+import ..Hecke: set_precision!, set_precision, is_absolutely_irreducible
 
 import Nemo: shift_left, shift_right
 import Base: *
-
-export factor_absolute, is_absolutely_irreducible
+export factor_absolute
 
 add_verbosity_scope(:AbsFact)
 add_assertion_scope(:AbsFact)