Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secretsmanager valuefrom task definition #68

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

raykrishardi
Copy link
Contributor

@raykrishardi raykrishardi commented Sep 20, 2023

Description:

When we want to use ssm param and secretsmanager as env var in ecs task definition, we need to input their ARN. However, currently for secretsmanager, the ARN does not seem to be generated
Screenshot 2023-09-20 at 9 06 26 pm

Screenshot 2023-09-20 at 6 20 10 pm

Before

config.yaml
Screenshot 2023-09-20 at 6 42 41 pm

compiled.yaml
Screenshot 2023-09-20 at 6 37 42 pm

After code changes

compiled.yaml
Screenshot 2023-09-20 at 6 41 48 pm

Diff changes

Screenshot 2023-09-20 at 9 16 38 pm

Test config.yaml

task_definition:
  nginx:
    repo: nginx
    image: nginx
    secrets:
      ssm:
        API_SECRET: /nginx/${EnvironmentName}/api/secret
      secretsmanager:
        ACCESSKEY: /dont/use/accesskeys
        SECRETKEY: /my/secret/${EnvironmentName}
        

targetgroup:
  name: nginx
  container: nginx
  port: 80
  protocol: http
  listener: http
  healthcheck:
    path: /
    code: 200

iam_policies:
  s3:
    action:
      - s3:GetObject
    resource:
      - arn:aws:s3::::bucket/*

Copy link
Contributor

@tarunmenon95 tarunmenon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! lgtm

@tarunmenon95 tarunmenon95 merged commit 1b79bae into theonestack:master Oct 1, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants