Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trvae update to 1.1.2 #136

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Trvae update to 1.1.2 #136

wants to merge 6 commits into from

Conversation

LuckyMD
Copy link
Collaborator

@LuckyMD LuckyMD commented Aug 4, 2020

This PR updates the trVAE function to work with version 1.1.2

To do:

  • update env
  • test locally
  • test on snakemake

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Aug 4, 2020

@M0hammadL please check if this looks correct to you!

@M0hammadL
Copy link
Member

M0hammadL commented Aug 4, 2020

THIS line has to change to :
conditions = adata.obs[batch].unique().tolist() and then pass :

network = trvae.models.trVAE(x_dimension=adata.shape[1],
                                 architecture=[256,64],
                                 z_dimension=10,
                                 gene_names=adata.var_names.tolist(),
                                 conditions=conditions,
                                 model_path='/localscratch/',
                                 alpha=0.0001,
                                 beta=50,
                                 eta=100,
                                 loss_fn='sse',
                                 output_activation='linear')

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Aug 4, 2020

I see, so you have to pass a list of the batches rather than the name of the batch covariate. Thanks!

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Aug 4, 2020

THIS line has to change to :
conditions = adata.obs[batch].unique().tolist() and then pass :

network = trvae.models.trVAE(x_dimension=adata.shape[1],
                                 architecture=[256,64],
                                 z_dimension=10,
                                 gene_names=adata.var_names.tolist(),
                                 conditions=conditions,
                                 model_path='/localscratch/',
                                 alpha=0.0001,
                                 beta=50,
                                 eta=100,
                                 loss_fn='sse',
                                 output_activation='linear')

@M0hammadL addressed with commit c92622a . All good now?

@LuckyMD LuckyMD mentioned this pull request Sep 11, 2020
@ilibarra
Copy link
Member

ilibarra commented Dec 2, 2020

@LuckyMD: What is the current status on running trVAE using scIB with snakemake? Would the latest trVAE version (1.1.2) work with the latest version of the scIB git? Maybe handled in another issue and overlooked it.

Thanks!

@LuckyMD
Copy link
Collaborator Author

LuckyMD commented Dec 2, 2020

trVAE from version 1.0 will only work with this PR, which we haven't merged yet, as it didn't pass initial testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants