Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate interactors to Deno #273

Closed
wants to merge 7 commits into from
Closed

Migrate interactors to Deno #273

wants to merge 7 commits into from

Conversation

wKich
Copy link
Member

@wKich wKich commented Aug 8, 2024

Motivation

In #264 we are adding @interactors/cli pacakge, which allows you to build interactors agent for injecting interactors in different environments and control them from outside. We'd like to distribute the CLI as a deps-free executable. But unfortunately there is no way to do it with node, even with SEA feature, because of esbuild, which can't be bundled. Hopefully in Deno there is esbuild package which downloads its binary in runtime and we can compile CLI executable

Approach

Migrate from Yarn monorepo to Deno workspace

Possible Drawbacks or Risks

I think we have to cut some pieces, like stories in material-ui interactors or maybe remove them completely, because they were made for the old mui version. Also remove sample app, which hasn't been updated quite long time

TODOs and Open Questions

  • How to control versions of packages (changeset alternative)
  • Move from npm binaries to deno task scripts, because deno doesn't download npm packages if they aren't used in code (It doesn't work)
  • Migrate from typedoc to deno doc
  • There are some lint issues in code, especially https://jsr.io/docs/about-slow-types#explicit-types, which can't be fixed in this PR
  • Migrate Github Actions
    • Public preview packages
    • Lint and test

Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 90ba86e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for interactors canceled.

Name Link
🔨 Latest commit 90ba86e
🔍 Latest deploy log https://app.netlify.com/sites/interactors/deploys/66d5c03632e9310008637815

@wKich wKich requested review from cowboyd, taras and jbolda August 8, 2024 13:23
@cowboyd cowboyd closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants