Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore sign_rpms script, it's used in sign_stage_rpms #429

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Sep 20, 2024

This partially reverts "drop signing scripts that were used with koji"

Fixes: 39674f4

This partially reverts "drop signing scripts that were used with koji"

Fixes: 39674f4

SIGN_FLAGS=(--define "_gpg_sign_cmd_extra_args --pinentry-mode loopback --passphrase-file ${gpg_pass}" --define "_gpg_path $KEYDIR" --define="_gpg_name $SIGNER")

rpmdev-vercmp $(rpm --query --queryformat='%{EVR}' rpm) 4.16.0 || RESULT=$?

Check warning

Code scanning / shellcheck

Quote this to prevent word splitting. Warning

Quote this to prevent word splitting.
fi

if [[ -n $1 ]] ; then
echo "$@" | xargs $XARGS_JOBS rpmsign --addsign "${SIGN_FLAGS[@]}"

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
if [[ -n $1 ]] ; then
echo "$@" | xargs $XARGS_JOBS rpmsign --addsign "${SIGN_FLAGS[@]}"
else
find "$RPMDIR" -name '*.rpm' | xargs $XARGS_JOBS rpmsign --addsign "${SIGN_FLAGS[@]}"

Check warning

Code scanning / shellcheck

Use -print0/-0 or -exec + to allow for non-alphanumeric filenames. Warning

Use -print0/-0 or -exec + to allow for non-alphanumeric filenames.
if [[ -n $1 ]] ; then
echo "$@" | xargs $XARGS_JOBS rpmsign --addsign "${SIGN_FLAGS[@]}"
else
find "$RPMDIR" -name '*.rpm' | xargs $XARGS_JOBS rpmsign --addsign "${SIGN_FLAGS[@]}"

Check notice

Code scanning / shellcheck

Double quote to prevent globbing and word splitting. Note

Double quote to prevent globbing and word splitting.
@evgeni evgeni merged commit 822f848 into master Sep 20, 2024
2 of 3 checks passed
@evgeni evgeni deleted the fix-signing branch September 20, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant