Expose the container registry URL #30
Conversation
Today Katello constructs this URL, but we're in a far better position to determine this. The installer can also explicitly set this since it already knows it. It also expands the sample config to further document what the settings are and how to use them. While not used in production by us (the installer overwrites it), it is helpful to provide context.
| #:pulp_url: https://localhost:24817/ | ||
| # Only set this if the container registry is present. This points to pulpcore-api. | ||
| # Can also be set to true in which case it'll be derived from pulp_url | ||
| #:container_registry_url: https://localhost:24817/pulpcore_registry |
There was a problem hiding this comment.
I think the part about pulpcore-api is incorrect. The registry endpoint is present on the content app.
Can you have the registry end point running at a different host:port combo that the content app? @jlsherrill
There was a problem hiding this comment.
Are you certain? I based this on https://github.com/theforeman/puppet-pulpcore/blob/7a5543b1a47de8d76a1cad1fb76e12db7bbf8e45/manifests/plugin/container.pp#L9-L21.
Now that look I see we also have an Ansible Galaxy endpoint:
https://github.com/theforeman/puppet-pulpcore/blob/7a5543b1a47de8d76a1cad1fb76e12db7bbf8e45/manifests/plugin/ansible.pp#L6-L16
Perhaps that should be exposed as well so Katello doesn't have to guess. @jlsherrill is that used anywhere within Katello?
There was a problem hiding this comment.
This https://github.com/Katello/katello/pull/9450/files#diff-bda566f2c5501c43867744c439cd22a7686af2940052749f3414e7b10c51308cR29-R30 constructs it based on the content app URL. I guess I don't right know which is which right at the moment. Save us Obi-Wan
Today Katello constructs this URL, but we're in a far better position to determine this. The installer can also explicitly set this since it already knows it.
It also expands the sample config to further document what the settings are and how to use them. While not used in production by us (the installer overwrites it), it is helpful to provide context.
This still needs some tests.