Add Ruby 3.0 + Puppet 7 & 3.2 + Puppet 8 to CI

[archanaserver]

Update Ruby ~> 3 and Puppet ~> 8

[ekohl]

We still want to keep testing on the old versions, just add the new versions.

[ekohl]

Instead of [WIP] you can also mark the PR as a draft (https://github.blog/2019-02-14-introducing-draft-pull-requests/).

[evgeni]

The tests execute now and the failure is related.

The internal kafo configure Module is not marked as compatible with Puppet 8:

kafo/modules/kafo_configure/metadata.json

Line 12 in e8d1a1e

"version_requirement": ">= 4.5.0 < 8.0.0"

Not sure if just bumping this would be sufficient, but certainly worth a try

[archanaserver]

@ekohl @evgeni is there a way to check, if the test was still skipped on the previous changes?

[evgeni]

@ekohl @evgeni is there a way to check, if the test was still skipped on the previous changes?

What do you mean by "on the previous changes"? The ones before you pushed today?

You can see previous runs in https://github.com/theforeman/kafo/actions

And they did not skip the "Tests" part, as there "Rubocop" succeeded.

Seems Rubocop 1.59 is rather new (https://github.com/rubocop/rubocop/releases/tag/v1.59.0) and triggers those errors.
I know they passed with 1.56.4, but no idea if any version inbetween is also good.

We should archive the Gemfile.lock generated in theforeman/actions/.github/workflows/rubocop.yml, so we can trace such issues easier.

[evgeni]

theforeman/actions#25

[archanaserver]

I can't see this rubocop failure in my local, also i just remembered that i've already fix these two cops here https://github.com/theforeman/kafo/blob/master/.rubocop.yml#L156-L160, don't know why it is failing here?

[ehelms]

This is what fixed the cops erroring for me:

diff --git a/lib/kafo/kafo_configure.rb b/lib/kafo/kafo_configure.rb
index be0a469..9cbdb70 100644
--- a/lib/kafo/kafo_configure.rb
+++ b/lib/kafo/kafo_configure.rb
@@ -120,7 +120,7 @@ module Kafo
       request_config_reload if applied_total > 0
 
       if ARGV.include?('--migrations-only')
-        verbose = (ARGV.include?('--verbose') || ARGV.include?('-v'))
+        verbose = ARGV.include?('--verbose') || ARGV.include?('-v')
         Logging.setup(verbose: verbose)
         self.class.logger.notice('Log buffers flushed')
         self.class.exit(0)
diff --git a/lib/kafo/param.rb b/lib/kafo/param.rb
index 363e16b..cf5047f 100644
--- a/lib/kafo/param.rb
+++ b/lib/kafo/param.rb
@@ -161,7 +161,7 @@ module Kafo
 
     def normalize_value(value)
       case value
-        when ::HighLine::String  # don't persist highline extensions
+        when ::HighLine::String # don't persist highline extensions
           value.to_s
         when Array
           value.map { |v| normalize_value(v) }
diff --git a/lib/kafo/progress_bar.rb b/lib/kafo/progress_bar.rb
index a10810e..ec32f71 100644
--- a/lib/kafo/progress_bar.rb
+++ b/lib/kafo/progress_bar.rb
@@ -34,7 +34,7 @@ module Kafo
       @all_lines += 1
 
       # we print every 20th line during installation preparing otherwise only update at EVALTRACE_START
-      update_bar = (@total == :unknown && @all_lines % 20 == 0)
+      update_bar = @total == :unknown && @all_lines % 20 == 0
       force_update = false
 
       if (line_monitor = MONITOR_RESOURCE.match(line))

[archanaserver]

@ehelms thanks, i got it!

[evgeni]

One could argue this should be 3 commits ("make code compliant with latest rubocop", "mark kafo_configure module as compatible with puppet 8" and "include Ruby 3 and Puppet 8 in test matrix"), but I am not going to nitpick here :)

[archanaserver]

Thank you for the review.