Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - extracting new, pulling from tx #620

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

ofedoren
Copy link
Member

@ofedoren ofedoren commented Nov 2, 2023

No description provided.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I would have expected that the removal of rackspace would have some impact on the strings that get extract, but apparently not. The only things that seem to be changed are metadata and comments in the pot file. Do we want to get this in even if the changes most likely won't be visible to the users?

@ofedoren
Copy link
Member Author

ofedoren commented Nov 3, 2023

I'd say why not? :) If it doesn't break anything though.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, lgtm

@adamruzicka adamruzicka merged commit 199add1 into theforeman:master Nov 3, 2023
6 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants