Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refresh pillar data on host update #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattiasgiese-b1
Copy link

This PR is currently not finished and should not be merged. I want to start a discussion about how to integrate such a feature.
Our usecase:

We want to be able to use the Salt environment set in the hosts pillar data as the env for the minion. In order to do this we need
a little change in Salt (see saltstack/salt#60233) and a new command in the proxy plugin (see theforeman/smart_proxy_salt#65)

This works well, but now i hit a roadblock with the code in this PR. Because salt-master will run foreman-node (and therefor update the minions grains) it will trigger another host update, which in turn triggers a update of the hosts grains, resulting in an endless loop.
Is there any way to check whether the user has adjusted the Salt environment itself to only trigger the refresh of pillar data if that's the case?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants