-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37642 - Drop compatibility with smart_proxy_openscap < 0.6.1 #575
Conversation
Test failures seem related to the changes. |
Yes, I missed something in the tests. Updated. |
hello, I ran oscap-related tests from robottelo against stream with this PR's packit, the results matched with what we have seen with the latest stream snap |
If this was still needed, we could use capabilities and easily check this statically but version 0.6.1 was released in 2017 so by now it's safe to assume it's new enough. Dropping the old code makes it more reliable and we have less code to maintain.
Updated the commit message to refer to a Redmine issue. No content change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
If this was still needed, we could use capabilities and easily check this statically but version 0.6.1 was released in 2017 so by now it's safe to assume it's new enough.
Dropping the old code makes it more reliable and we have less code to maintain.
I must admit I've only grepped through the source and am not that familiar with the codebase, so it realistic that I missed something.