Fixes #37619 - Add ouia-ids for remediation wizard #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
reviewed
Jul 3, 2024
webpack/components/ConfirmModal.js
Outdated
| @@ -11,6 +11,7 @@ const ConfirmModal = props => { | |||
|
|
|||
| const actions = [ | |||
| <Button | |||
| ouiaId={`oscap-conf-modal-${props.record.id}-confirm`} | |||
There was a problem hiding this comment.
props.record default is null. so this should be props.record?.id or something else
There was a problem hiding this comment.
Fixed. Although, anything that is fixed here and is not related to the wizard should be removed, since those are leftovers from OVAL additions.
MariaAga
reviewed
Jul 3, 2024
.github/workflows/js_tests.yml
Outdated
Comment on lines
30
to
32
| - name: Run plugin linter | ||
| run: | | ||
| npm run lint |
There was a problem hiding this comment.
This already runs as part of foreman_plugin_js
There was a problem hiding this comment.
maybe we should add it there, but thats a different pr 🙃
|
Thanks, @MariaAga, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MariaAga, could you please take a look?