Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37567 - Remove OVAL related permissions from DB #573

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fixes #37567 - Remove OVAL related permissions from DB #573

merged 1 commit into from
Jun 20, 2024

Conversation

ofedoren
Copy link
Member

@adamruzicka, could you please take a look?

@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch from 31e8e45 to ebe2eac Compare June 17, 2024 14:32
@adamruzicka
Copy link
Contributor

While you're at it, could you also purge the leftover "Run OVAL scans" job template?

@ofedoren
Copy link
Member Author

While you're at it, could you also purge the leftover "Run OVAL scans" job template?

The template itself was removed in dbcc884#diff-d2ebe35d256df63ef93a7062c78a5194f44c04e45f5bb55be70804530f1e2efe.

I've added here removal of the REX feature that used the template: https://github.com/theforeman/foreman_openscap/pull/573/files#diff-a7788fa0965fa49767991277a92525fc9cc6aa277213e848b5c805d1de7cd0dbR8

@adamruzicka
Copy link
Contributor

The template itself was removed

But if it was seeded in the meantime, it will stick around, no?

@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch from ebe2eac to df27497 Compare June 18, 2024 13:28
@ofedoren
Copy link
Member Author

The template itself was removed

But if it was seeded in the meantime, it will stick around, no?

Yes, you're right. Sorry, I kinda read it in a different way than you meant, fixed now.

@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch 2 times, most recently from b02512a to c588f64 Compare June 18, 2024 15:46
@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch from c588f64 to 92e2af4 Compare June 19, 2024 12:27
@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch 3 times, most recently from 05923df to eec42af Compare June 19, 2024 17:43
@ofedoren ofedoren force-pushed the bug-37567-remove-oval-perms branch from eec42af to a8cc7bc Compare June 19, 2024 17:49
@ofedoren
Copy link
Member Author

Thanks, @adamruzicka, should be fixed now.

adamruzicka
adamruzicka approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit b7f6bec into theforeman:master Jun 20, 2024
26 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofedoren @adamruzicka