-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37061 - Mention SEED_ADMIN_PASSWORD in DEV docs #9996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please motivate why this is a good thing. There is no context in the issue or in the commit message. Explaining your thought process is very important to me.
eb7a0be
to
3e36c5f
Compare
@ekohl sorry, was too hasty with pushing the PR, thinking "the headline" is enough. Commit message & PR description update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda okay with the changes.
Question though: if it's more for the newcomers, should we maybe point out in the docs that for custom passwords SEED_ADMIN_PASSWORD
env variable can/should be used instead? I guess the first thing what a newcomer would do is to read installation steps anyway...
3e36c5f
to
0e9269a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if we have it mentioned in the docs, why would we have the default changeme
anyway? :)
🤔 I guess you are right, document it is enough. |
0e9269a
to
59677e7
Compare
59677e7
to
3433970
Compare
Well, LGTM, but it appears that we have the same as part of #9906. Should we maybe merge that instead? (sorry @stejskalleos, should've found it earlier than make you make changes here :/) |
I've merged my own PR since I can bypass the checks. I think that obsoletes this PR. |
No description provided.