Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37061 - Mention SEED_ADMIN_PASSWORD in DEV docs #9996

Closed
wants to merge 1 commit into from

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Jan 18, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please motivate why this is a good thing. There is no context in the issue or in the commit message. Explaining your thought process is very important to me.

@stejskalleos
Copy link
Contributor Author

@ekohl sorry, was too hasty with pushing the PR, thinking "the headline" is enough.

Commit message & PR description update.

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda okay with the changes.

Question though: if it's more for the newcomers, should we maybe point out in the docs that for custom passwords SEED_ADMIN_PASSWORD env variable can/should be used instead? I guess the first thing what a newcomer would do is to read installation steps anyway...

@stejskalleos
Copy link
Contributor Author

SEED_ADMIN_PASSWORD added to the DEV doc

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if we have it mentioned in the docs, why would we have the default changeme anyway? :)

@stejskalleos
Copy link
Contributor Author

🤔 I guess you are right, document it is enough.

@stejskalleos stejskalleos changed the title Fixes #37061 - In DEV env generate admin with 'changeme' password Fixes #37061 - Mention SEED_ADMIN_PASSWORD in DEV docs Feb 19, 2024
@ofedoren
Copy link
Member

Well, LGTM, but it appears that we have the same as part of #9906. Should we maybe merge that instead? (sorry @stejskalleos, should've found it earlier than make you make changes here :/)

@ekohl
Copy link
Member

ekohl commented Feb 19, 2024

I've merged my own PR since I can bypass the checks. I think that obsoletes this PR.

@ekohl ekohl closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants