use the values from matrix.json in JS tests #9880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 27, 2023
This was referenced Oct 27, 2023
evgeni
force-pushed
the
load-matrix-in-js-tests
branch
2 times, most recently
from
58654d1
to
e7d0e17
Compare
ekohl
reviewed
Oct 31, 2023
ekohl
reviewed
Oct 31, 2023
ekohl
reviewed
Oct 31, 2023
| matrix: | ||
| node-version: | ||
| - 14 | ||
| matrix: ${{ fromJson(needs.setup_matrix.outputs.matrix) }} |
There was a problem hiding this comment.
I wonder if we can somehow be smart and only test on the first Ruby version. Running the JS tests with all Ruby versions probably doesn't make sense.
Suggested change
| matrix: ${{ fromJson(needs.setup_matrix.outputs.matrix) }} | |
| matrix: | |
| ruby: | |
| - ${{ fromJson(needs.setup_matrix.outputs.matrix).ruby[0] }} | |
| node: ${{ fromJson(needs.setup_matrix.outputs.matrix).node }} |
But perhaps with webpack 5 the webpack config no longer executes Ruby to determine plugins (not sure, couldn't see it immediately) and it no longer needs Ruby.
ekohl
approved these changes
Oct 31, 2023
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
evgeni
force-pushed
the
load-matrix-in-js-tests
branch
from
3de15eb
to
e64dcf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.