Fixes #36864 - Show entire opened bookmarks properly #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmalyjur
changed the title
MariaAga
reviewed
Nov 1, 2023
| @@ -2,6 +2,8 @@ | |||
| @import '../../common/variables.scss'; | |||
|
|
|||
| .react-page #foreman-main-container { | |||
| overflow-x: auto; | |||
| white-space: nowrap; | |||
There was a problem hiding this comment.
When its set to nowrap audits page can look weird for long entries (to test create a long bookmark in audits and refresh the page, and open the new bookmark entry).
Will this fix work with white-space: normal? I checked it in a few places and it looks fine
There was a problem hiding this comment.
You're right, I missed that. I changed it to white-space: normal, it looks fine to me, too. Thank you!
MariaAga
approved these changes
Nov 7, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bookmarks were opened to the left side before, which caused problems with long names:
The bookmarks are now opened to the right side, and a horizontal scrollbar is added if it exceeds the page:
