Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actions/labeler to apply directory labels #9826

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 7, 2023

Today the legacy PR processor is used to apply directory labels, but it is the only repository to do so. This uses a common GitHub Action to do the same thing. Another benefit is that the configuration now lives close to the code.

A possible downside is that if there are changes, it needs to be cherry picked. That's unlikely, given how little these change. It may even be a benefit when files move around. It gives the possibility to use different labels in different branches.

Today the legacy PR processor is used to apply directory labels, but it
is the only repository to do so. This uses a common GitHub Action to do
the same thing. Another benefit is that the configuration now lives
close to the code.

A possible downside is that if there are changes, it needs to be cherry
picked. That's unlikely, given how little these change. It may even be a
benefit when files move around. It gives the possibility to use
different labels in different branches.
@ekohl
Copy link
Member Author

ekohl commented Sep 11, 2023

theforeman/prprocessor#181 removes it from prprocessor.

@ekohl ekohl merged commit 5cd17c6 into theforeman:develop Sep 11, 2023
7 of 8 checks passed
@ekohl ekohl deleted the add-labeler branch September 11, 2023 10:13
@ekohl
Copy link
Member Author

ekohl commented Sep 11, 2023

7b2e415..8a56a14 3.6-stable -> 3.6-stable
531305a..35baa12 3.7-stable -> 3.7-stable
6e4c093..5ee0798 3.8-stable -> 3.8-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants