Fixes #36677 - Added BOOTIF-parameter to autoinstall kernel_options #9806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36677 |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
app/views/unattended/provisioning_templates/snippet/preseed_kernel_options_autoinstall.erb
Outdated
Show resolved
Hide resolved
jtruestedt
force-pushed
the
fix_36677_bootif_autoinstall
branch
from
c375ea9
to
d67915e
Compare
sbernhard
approved these changes
Aug 22, 2023
|
@sbernhard the tests didn't run on this job and broke nightly (https://community.theforeman.org/t/foreman-develop-source-release-1996-failed/34788 / https://ci.theforeman.org/job/foreman-develop-source-release/1996/). When @theforeman-bot says "Can one of the admins verify this patch?" you need to say |
|
sorry. I will fix the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://projects.theforeman.org/issues/36677
Other that for kickstart the mac has to be separated with : instead of -
That change only makes a difference, if you try to provision hosts with more than one network interface.