Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36656 - Pin @adobe/css-tools to 4.2.0 #9799

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fixes #36656 - Pin @adobe/css-tools to 4.2.0 #9799

merged 1 commit into from
Aug 8, 2023

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Aug 8, 2023

No description provided.

@sjha4 sjha4 requested a review from a team as a code owner August 8, 2023 15:26
@theforeman-bot
Copy link
Member

Issues: #36656

@theforeman-bot
Copy link
Member

Issues: #36656

@evgeni
Copy link
Member

evgeni commented Aug 8, 2023

is that something that needs packaging, or shall we add it to the exclude list?

@ofedoren
Copy link
Member

ofedoren commented Aug 8, 2023

Why exactly do we need to pin the lib instead of update node version in CI?..

@jeremylenz
Copy link
Contributor

jeremylenz commented Aug 8, 2023 •
edited
Loading

Why exactly do we need to pin the lib instead of update node version in CI?..

We're stuck on node 12 downstream for the time being, as I understand it. We had previously upgraded node here in Github Actions and then had to revert it.

@ofedoren
Copy link
Member

ofedoren commented Aug 8, 2023

We're stuck on node 12 downstream for the time being

oof 😞 Okay then. At least there is a reason...

@ofedoren ofedoren mentioned this pull request Aug 8, 2023
Merged
@sjha4
Copy link
Contributor Author

sjha4 commented Aug 8, 2023

Updated to add this as dev-dependency and added it exclude list..I didn't see it being packaged and package-lock shows dev: true for this in foreman and katello.

evgeni
evgeni previously approved these changes Aug 8, 2023
View reviewed changes
jeremylenz
jeremylenz previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ 👍

ekohl
ekohl reviewed Aug 8, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@sjha4 sjha4 dismissed stale reviews from jeremylenz and evgeni via d0e198e August 8, 2023 18:17
@jeremylenz jeremylenz requested a review from evgeni August 8, 2023 18:51
@evgeni evgeni merged commit 7b74d9d into theforeman:develop Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjha4 @theforeman-bot @evgeni @ofedoren @jeremylenz @ekohl