Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36587 - rename Host - Applicable Errata report #9791

Conversation

ianballou
Copy link
Contributor

@ianballou ianballou commented Aug 3, 2023

  • ...and fix comment typos

Renames the applicable errata report since it no longer only reports on applicable errata.

Also, remove some odd characters that look like whitespace in GitHub but really aren't. They were breaking syntax highlighting in Foreman.

To test:

  1. Create a report template called "Host - Available Errata"
  2. Apply this PR and run the migration
  3. Ensure that the report template you created is backed up under a different name
  4. Ensure that the "Host - Available Errata" report has what the "Host - Applicable Errata" report used to have
  5. Ensure that the "Host - Applicable Errata" report is gone
  6. Ensure that the syntax highlighting is not broken for "Host - Available Errata" or "Host - Registered Content Hosts"

@theforeman-bot
Copy link
Member

Issues: #36587

Copy link
Contributor

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before PR:
Screenshot from 2023-08-04 13-14-48
After PR:
Migration_successful
Screenshot from 2023-08-04 13-15-30
Ack 👍🏼

@ianballou
Copy link
Contributor Author

@sjha4 your ACK is a comment xD

Copy link
Contributor

@sjha4 sjha4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack..I don't have write access so we need another Ack on this though..

Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK based on Samir's ack. 👍

@ianballou ianballou merged commit 75d8ea3 into theforeman:develop Aug 7, 2023
4 checks passed
@ianballou ianballou deleted the 36587-applicable-errata-report-fixing branch August 7, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants