-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36518 - show disk/partitions of vsphere host #9740
Conversation
Issues: #36518 |
fog/fog-vsphere#284 was merged yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a change to require a gem release of fog-vsphere which includes the patch.
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Outdated
Show resolved
Hide resolved
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Show resolved
Hide resolved
...javascripts/react_app/components/HostDetails/Tabs/Details/Cards/Virtualization/VirtVmware.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbernhard!
@sbernhard I merged it and remembered I forgot to test it with fog-vsphere v3.6.0, and it breaks the vm card in host details page (legacy and new) |
Requires fog/fog-vsphere#284