Fixes #37912 - Correct Puppet server in Windows default user data template #10347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate It should use the host_puppet_server macro to determine the Puppet server for a given host, not some unattended URL with a hardcoded token. Fixes: 6470fc4 ("Fixes #36161 - Add windows default user data template")
nadjaheitmann
approved these changes
Oct 15, 2024
|
Thanks @ekohl, this should definitely be fixed! |
sbernhard
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should use the
host_puppet_servermacro to determine the Puppet server for a given host, not some unattended URL with a hardcoded token.Fixes: 6470fc4 ("Fixes #36161 - Add windows default user data template")
@nadjaheitmann could you take a look?