Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37459 - update rubocop todo file #10081

Closed
wants to merge 1 commit into from
Closed

Fixes #37459 - update rubocop todo file #10081

wants to merge 1 commit into from

Conversation

archanaserver
Copy link
Contributor

@archanaserver archanaserver commented Mar 6, 2024 •
edited
Loading

@archanaserver archanaserver marked this pull request as ready for review May 15, 2024 08:53
@archanaserver
Copy link
Contributor Author

@ekohl here's the track of all the foreman cops fix, in case you are looking for.

@archanaserver archanaserver force-pushed the rubocop-todo branch 2 times, most recently from ac298ed to ee988da Compare May 15, 2024 09:44
@archanaserver archanaserver changed the title Update rubocop todo file Fixes #37459 - update rubocop todo file May 15, 2024
ekohl
ekohl requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be part of #9926. Could you combine both of them?

@archanaserver
Copy link
Contributor Author

I have combine this changes in #9926, so marking it as a draft for now.

@archanaserver archanaserver marked this pull request as draft August 1, 2024 11:15
@archanaserver archanaserver deleted the rubocop-todo branch October 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl requested changes

Assignees
No one assigned
Labels
Waiting on contributor
Projects
RuboCop upgrade
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archanaserver @ekohl