Refs #18539 - Introduce foreman_plugin_files in foreman.macros #11190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But this also means we need to adjust every single plugin spec, while just adjusting the existing macros does not require it? |
|
True, but the idea I have is to and up with less logic in Perhaps it's better to separate that out, but I wanted to see. Friday always has time for a bit of experimentation, right? |
This allows plugins to use %files -f foreman_plugin_files and automatically get the correct files section, based on the foreman_bundlerd_file and foreman_precompile_plugin macros (and their options).
ekohl
force-pushed
the
rpm/develop-18539-introduce-plugin-files-in-macro
branch
from
5198019
to
133fd0e
Compare
ekohl
commented
Aug 30, 2024
| @@ -678,6 +678,7 @@ cat > %{buildroot}%{_sysconfdir}/rpm/macros.%{name}-plugin << EOF | |||
| # -n<plugin_name> Overrides default of gem_name | |||
| %%%{name}_bundlerd_file(n:) \\ | |||
| mkdir -p %%{buildroot}%%{%{name}_bundlerd_dir} \\ | |||
| echo %%{%{name}_bundlerd_dir}/%%{-n*}%%{!?-n:%%{gem_name}} >> %%%{name}_plugin_files \\ | |||
There was a problem hiding this comment.
Note to self: this and other cases need to be
Suggested change
| echo %%{%{name}_bundlerd_dir}/%%{-n*}%%{!?-n:%%{gem_name}} >> %%%{name}_plugin_files \\ | |
| echo %%{%{name}_bundlerd_dir}/%%{-n*}%%{!?-n:%%{gem_name}} >> %{name}_plugin_files \\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows plugins to use
%files -f foreman_plugin_filesand automatically get the correct files section, based on theforeman_bundlerd_fileandforeman_precompile_pluginmacros (and their options).