Include GPG keys in katello-repos and check for non-nightly #11128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
rpm/develop-katello-repos-gpg
branch
from
1aec007
to
7b643fd
Compare
This was referenced Aug 15, 2024
Including the GPG keys is better because it gives a higher degree of trust because the RPM is GPG signed. It also helps because dnf doesn't refresh HTTPS URLs and purging old entries is tedious. While the repos aren't typically installed that long, I've had it happen to me with one of my personal COPR repositories. The downside is that after branching you need to update the GPG key in the repository. It also makes GPG key checking correct by looking at the correct values. This allows enabling GPG for candlepin (which is using a signed release) while not enabling it for Pulp or Katello (which are nightly).
ekohl
force-pushed
the
rpm/develop-katello-repos-gpg
branch
from
7b643fd
to
fbf8836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the GPG keys is better because it gives a higher degree of trust because the RPM is GPG signed. It also helps because dnf doesn't refresh HTTPS URLs and purging old entries is tedious. While the repos aren't typically installed that long, I've had it happen to me with one of my personal COPR repositories.
The downside is that after branching you need to update the GPG key in the repository.
It also makes GPG key checking correct by looking at the correct values. This allows enabling GPG for candlepin (which is using a signed release) while not enabling it for Pulp or Katello (which are nightly).