Add a filter parameter for bump_packages #11101
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying this filter allows calling it from a specific plugin to only update a single package. For example, when a gem is released it can automatically trigger this workflow.
evgeni
reviewed
Aug 14, 2024
| inputs: | ||
| filter: | ||
| type: string | ||
| description: A filter to apply on package names |
There was a problem hiding this comment.
Package names have different structure between Debian and EL. Should this filter rather be on the "source" name?
So, passing foreman_maintain here will update ruby-foreman-maintain on Debian and rubygem-foreman_maintain on RPM?
There was a problem hiding this comment.
I think so. In the update scripts we know the gem name so we can match against that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying this filter allows calling it from a specific plugin to only update a single package. For example, when a gem is released it can automatically trigger this workflow.
Right now the actual scripts don't implement this, so this is just a proposal. My idea is that we enhance our release-gem workflow to trigger a packaging bump. That way we don't update all existing PRs but still have nice end-to-end automation for nightly. Stable branches still need additional work.