Fixes #37874 - don't try to swap modules, this can fail #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead use single-user mode cluster based on the postgresql-upgrade binaries
ehelms
reviewed
Oct 2, 2024
| line.match(/dat(collate|ctype)\s+=\s+(\S+)/) do |m| | ||
| data[m[1]] = m[2].delete('"') | ||
| end | ||
| end |
There was a problem hiding this comment.
Yeah, the output in single user mode is a bit eww (well, it's used for debugging, not running real stuff), and we gotta parse that. :/
There was a problem hiding this comment.
Using /dat(collate|ctype)\s+=\s+"(\S+)"/ as the regex removes the need for .delete('"'), making it more ew than ewwww.
I do wonder about error handling: what if data doesn't contain any values because the process failed to start up?
There was a problem hiding this comment.
Then the upgrade will fail as we pass invalid data in PGSETUP_INITDB_OPTIONS -- nothing new compared to how it was before this whole hack 🙈
ehelms
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead use single-user mode cluster based on the postgresql-upgrade
binaries