-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide plug-in uninstallation procedures for Satellite #3112
Conversation
The PR preview for 7fa1fc4 is available at theforeman-foreman-documentation-preview-pr-3112.surge.sh The following output files are affected by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
Acked by @evgeni from the technical point of view recently over slack. |
Thanks for stepping in to merge @Lennonka but next time, could you please wait a bit more? This PR has been opened for only 40 minutes. I find it best to wait for at least about a day unless the update is critical. There is always a chance that someone else will offer valuable insight. |
If Satellite depends on the plugins and are always present then shouldn't we hide the installation too? |
We should also drop all |
@ekohl Will what you're suggesting be covered by https://issues.redhat.com/browse/SAT-26276? |
Depends. That issue certainly was inspired by this PR, though it's something I thought about for longer. We must remove the exact instructions for that issue (if we move forward with it), but that doesn't stop us from cleaning it up already (since it's redundant). |
Great, thanks for clarifying. The best I can do right now is to create an issue: #3114 |
https://issues.redhat.com/browse/SAT-25665 This PR hides a few procedures for uninstalling Foreman plug-ins for Satellite builds. Satellite depends on these plug-ins and they cannot be uninstalled.
Please cherry-pick my commits into: