Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide plug-in uninstallation procedures for Satellite #3112

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

asteflova
Copy link
Contributor

@asteflova asteflova commented Jul 8, 2024

https://issues.redhat.com/browse/SAT-25665 This PR hides a few procedures for uninstalling Foreman plug-ins for Satellite builds. Satellite depends on these plug-ins and they cannot be uninstalled.

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@asteflova asteflova changed the title Satellite depends on these plug-ins and they cannot be uninstalled Hide plug-in uninstallation procedures for Satellite Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@asteflova
Copy link
Contributor Author

Acked by @evgeni from the technical point of view recently over slack.

@Lennonka Lennonka merged commit 3259af8 into theforeman:master Jul 8, 2024
8 checks passed
@Lennonka
Copy link
Contributor

Lennonka commented Jul 8, 2024

Cherry-picked:

@asteflova
Copy link
Contributor Author

Thanks for stepping in to merge @Lennonka but next time, could you please wait a bit more? This PR has been opened for only 40 minutes. I find it best to wait for at least about a day unless the update is critical. There is always a chance that someone else will offer valuable insight.

@ekohl
Copy link
Member

ekohl commented Jul 8, 2024

If Satellite depends on the plugins and are always present then shouldn't we hide the installation too?

@ekohl
Copy link
Member

ekohl commented Jul 8, 2024

We should also drop all --enable-foreman-compute-* sections for Satellite because they're mandatory. There's also a list of Foreman & Hammer plugins we always install so we should also drop the explicit enablement of those.

@asteflova
Copy link
Contributor Author

@ekohl Will what you're suggesting be covered by https://issues.redhat.com/browse/SAT-26276?

@ekohl
Copy link
Member

ekohl commented Jul 9, 2024

Depends. That issue certainly was inspired by this PR, though it's something I thought about for longer. We must remove the exact instructions for that issue (if we move forward with it), but that doesn't stop us from cleaning it up already (since it's redundant).

@asteflova
Copy link
Contributor Author

Great, thanks for clarifying. The best I can do right now is to create an issue: #3114

@asteflova asteflova deleted the SAT-25665_sat-plugins branch July 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants