support hidden values when creating params #1785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
hidden-parameters
branch
4 times, most recently
from
f02612b
to
8472cf7
Compare
evgeni
commented
Oct 8, 2024
| @@ -1094,6 +1097,15 @@ def _update_entity(self, resource, desired_entity, current_entity, params, forem | |||
| sort_key = 'name' | |||
| else: | |||
| sort_key = list(value[0].keys())[0] | |||
| # special handling for parameters created by ParametersMixin | |||
There was a problem hiding this comment.
@mdellweg how much of a decontamination shower do you need after reading this?
evgeni
force-pushed
the
hidden-parameters
branch
2 times, most recently
from
76560e3
to
2ee1161
Compare
evgeni
force-pushed
the
hidden-parameters
branch
from
2ee1161
to
c0ad1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.