Update microWakeWord Model definition for 2024.7 release #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetele
added
breaking-change
tetele
reviewed
Jul 17, 2024
|
Thanks, i'll test and get back ASAP. |
jhbruhn
commented
Jul 18, 2024
|
What's still missing for this PR to be merged? |
|
I'd also love to try this. I can help with testing on my onju home. |
dreimer1986
added a commit
to dreimer1986/onju-voice-satellite
that referenced
this pull request
Aug 3, 2024
tetele
approved these changes
Aug 7, 2024
tetele
pushed a commit
that referenced
this pull request
Aug 7, 2024
* Update microWakeWord Model definition for 2024.7 release * Update minimum ESPHome version in Readme to 2024.7.0, add comment for hey mycroft wakeword * Change microwakeword restart-preposition back to media_player.is_playing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent ESPHome release uses a different definition for the microwakeword models (which have also been updated). This adds that definition.
I also added a change in line 241 (voice_assistant.on_end) because at least for me, the pipeline often times did not restart after it had finished.