docs: Upate React example usage with MSW to mention that fetch will require polyfill #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the example notes re: MSW to mention that jsdom doesn't include fetch and will require a polyfill
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MatanBobi
reviewed
Aug 30, 2024
| @@ -72,6 +72,8 @@ We recommend using the | |||
| declaratively mock API communication in your tests instead of stubbing | |||
| `window.fetch`, or relying on third-party adapters. | |||
|
|
|||
| Our example here uses axios to make its API calls. If your application uses [`fetch()`][https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch] to make its API calls, then be aware that by default JSDOM does not include fetch. If you are using vitest as your test runner, it will be included for you. For jest you may wish to manually polyfill `fetch()` or use the [jest-fixed-jsdom](https://github.com/mswjs/jest-fixed-jsdom) environment which includes fetch. | |||
There was a problem hiding this comment.
Thanks! Any chance you can please add the note admonition here around this?
:::note
:::
dwjohnston
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the example notes re: MSW to mention that jsdom doesn't include fetch and will require a polyfill