Fixing HexBlock rotation in plotBlockDiagram

[john-science]

What is the change?

1. Fixed a bug in plotBlockDiagram().
2. To help, I added the method HexBlock.cornersUp(), as I imagine it will be a helpful utility to have.
3. Oh, and sorry, I changed a variable from self.HexBlock to self.hexBlock, to match our variable naming rules.

Why is the change being made?

The method plotBlockDiagram() incorrectly plots HexBlocks if they are rotated to the "corners up" rotation.

close #1421

---

Checklist

• This PR has only one purpose or idea.
• Tests have been added/updated to verify any new/changed code.

• The code style follows good practices.
• The commit message(s) follow good practices.

• The release notes have been updated if necessary.
• The documentation is still up-to-date in the doc folder.
• The dependencies are still up-to-date in pyproject.toml.

[keckler]

First question without even looking at the code -- Can we get a picture of the correct plots?

[keckler]

I think also this chunk might need to be made aware of the orientation:
https://github.com/terrapower/armi/pull/1926/files#diff-0c52725b9d66a2bcefb306c31e4a9479fe8c206453c22b3e4cd268a1efef3c16R1181-R1185

[keckler]

@john-science Thank you for fixing those few comments. Please also note that there are a couple more things that would be good before approving this PR:

1. Fixing HexBlock rotation in plotBlockDiagram #1926 (review)
2. Fixing HexBlock rotation in plotBlockDiagram #1926 (comment)

[drewj-tp]

I'm currently poking around grid like things and some things here overlapped

[drewj-tp]

I guess this is false-like? But returning None from a bool-like method feels weird.

Would it make more sense to return False or error here?

[john-science]

A Python None is a null value. It is just as valid to use None for a null value when a return type is an int, numpy.ndarray or bool.

Seems standard enough to return an empty value from a method.

What would you rather do? I don't want to return an error, because this does not seem like a scenario in which I want to kill a simulation.

[john-science]

hmmm

[john-science]

@drewj-tp Well, in defense of your idea, I am still getting this:

It appears the bug for the hexagonal shaped composites was quite easy to fix. But the coordinates for the pins are just wrong from the start. (There's nothing I can do in the plotting routine to fix that.)

[john-science]

This PR is temporarily on hold for another PR: #1947

I believe my solution in this was over-engineered to work AROUND the problem present in the other PR. Once that other PR merges, I should be able to simplify this PR.