Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more detailed __lt__ for components. #1882

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

Implement more detailed __lt__ for components. #1882

wants to merge 37 commits into from

Commits on Sep 11, 2024

  1. Implement more detailed __lt__ for components.

    @mgjarrett
    mgjarrett committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    707aa88 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add a unit test for component sorting.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    35b63a8 View commit details
    Browse the repository at this point in the history

  2. Update release notes.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6bc7dc1 View commit details
    Browse the repository at this point in the history

  3. Address linting error

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1265d7c View commit details
    Browse the repository at this point in the history

  4. Catch NotImplementedError

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dbed10f View commit details
    Browse the repository at this point in the history

  5. Remove all of the circular imports in components.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0fd1632 View commit details
    Browse the repository at this point in the history

  6. Fix broken unit tests.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cca4a14 View commit details
    Browse the repository at this point in the history

  7. Fix unit test reference result.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    06f1ec1 View commit details
    Browse the repository at this point in the history

  8. Register RadialSegment component type.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37e8f0b View commit details
    Browse the repository at this point in the history

  9. Black formatting.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    af44807 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into component_sort

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    c65a0c3 View commit details
    Browse the repository at this point in the history

  11. Refactor more unit tests.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9cb98e5 View commit details
    Browse the repository at this point in the history

  12. Ignore unused import

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d50b6dc View commit details
    Browse the repository at this point in the history

  13. Revert "Refactor more unit tests." 

    This reverts commit 9cb98e5.
    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d1db895 View commit details
    Browse the repository at this point in the history

  14. Revert "Fix broken unit tests." 

    This reverts commit cca4a14.
    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6c891fd View commit details
    Browse the repository at this point in the history

  15. Revert "Remove all of the circular imports in components." 

    This reverts commit 0fd1632.
    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    914fe58 View commit details
    Browse the repository at this point in the history

  16. Clear merge conflict.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    88feb80 View commit details
    Browse the repository at this point in the history

  17. Revert trivial change.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0b1b6ef View commit details
    Browse the repository at this point in the history

  18. Add getCircleInnerDiameter for UnshapedComponent.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    12980cd View commit details
    Browse the repository at this point in the history

  19. Fix circular import.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a62fd41 View commit details
    Browse the repository at this point in the history

  20. Black formatting.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    acbf2fc View commit details
    Browse the repository at this point in the history

  21. Update docstring.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    53780e4 View commit details
    Browse the repository at this point in the history

  22. Address review comments.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2a7e4a1 View commit details
    Browse the repository at this point in the history

  23. One more review comment.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    64d1d09 View commit details
    Browse the repository at this point in the history

  24. Remove commented code.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    37e4310 View commit details
    Browse the repository at this point in the history

  25. Remove kwargs

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    80d57ab View commit details
    Browse the repository at this point in the history

  26. Black formatting

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9457b49 View commit details
    Browse the repository at this point in the history

  27. Fix namespace errors.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6dca45a View commit details
    Browse the repository at this point in the history

  28. Add getCircleInnerDiameter to RadialSegment. 

    Fix getBoundingCircleOuterDiameter to return a diameter instead of a
radius.
    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4e2234b View commit details
    Browse the repository at this point in the history

  29. Update armi/reactor/components/__init__.py 

    Co-authored-by: John Stilley <[email protected]>
    @mgjarrett @john-science
    mgjarrett and john-science authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    48603a4 View commit details
    Browse the repository at this point in the history

  30. Update doc/release/0.4.rst 

    Co-authored-by: John Stilley <[email protected]>
    @mgjarrett @john-science
    mgjarrett and john-science authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3ccdc5b View commit details
    Browse the repository at this point in the history

  31. Revert to main blocks.py

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2075f3a View commit details
    Browse the repository at this point in the history

  32. Revert import change.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5b601f9 View commit details
    Browse the repository at this point in the history

  33. Merge branch 'component_sort' of https://github.com/terrapower/armi i… 

    …nto component_sort
    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    15155be View commit details
    Browse the repository at this point in the history

  34. Revert more import changes.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7733ad8 View commit details
    Browse the repository at this point in the history

  35. Revert more imports.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9b61363 View commit details
    Browse the repository at this point in the history

  36. Fix an import.

    @mgjarrett
    mgjarrett committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b87c1d1 View commit details
    Browse the repository at this point in the history