Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with _finalizeInteract in serial jobs #1730

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fixing issue with _finalizeInteract in serial jobs #1730

merged 2 commits into from
Jun 14, 2024

Conversation

john-science
Copy link
Member

What is the change?

The new method OperatorMPI._finalizeInteract() does not work for serial jobs, this PR fixes that.

Why is the change being made?

A recent PR, a bug was introduced:

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the bug Something is wrong: Highest Priority label Jun 14, 2024
@john-science
Copy link
Member Author

@zachmprince Just FYI, this is due to your recent PR.

@john-science john-science merged commit a7a868b into main Jun 14, 2024
23 checks passed
@john-science john-science deleted the fix_finalize_interact branch June 14, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opotowsky opotowsky opotowsky approved these changes

Assignees
No one assigned
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-science @opotowsky