Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing docs build on MacOS, and fixing docs docs #1719

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Jun 2, 2024

What is the change?

Closes #1718 and adds a line in the .gitignore for .DS_Store files in MacOS.

Why is the change being made?

Functioning docs builds are good! And not accidentally ending up with a MacOS metadata file in the repo is ideal.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2024

CLA assistant check
All committers have signed the CLA.

@albeanth albeanth added the documentation Improvements or additions to documentation label Jun 2, 2024
@john-science john-science changed the title Fix docs install Fixing docs build on MacOS, and fixing docs docs Jun 3, 2024
@john-science john-science merged commit 514420c into terrapower:main Jun 3, 2024
12 checks passed
@john-science john-science deleted the fix_docs_install branch June 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in docs build instructions
3 participants